[PATCH] D63280: [llvm-objdump] Use <first-symbol>-<offset> as the section start symbol

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 13 19:34:33 PDT 2019


MaskRay added a comment.

In the context of PR41946:

  Disassembly of section .text:
  
  0000000000001000 .text:
      1000: 90                            nop

I agree that `0000000000001000 .text:` is not useful as it repeats what `Disassembly of section .text:` says. However, in the `bar at plt-0x10` case (when the PLT resolver stub doesn't get a symbol name), I'm not sure this improves readability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63280/new/

https://reviews.llvm.org/D63280





More information about the llvm-commits mailing list