[PATCH] D63301: [AMDGPU] gfx1010 wave32 icmp/fcmp intrinsic changes for wave32

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:252
   CallInst *const Ballot =
-      B.CreateIntrinsic(Intrinsic::amdgcn_icmp, {B.getInt32Ty()},
+      B.CreateIntrinsic(Intrinsic::amdgcn_icmp,
+                        {B.getInt64Ty(), B.getInt32Ty()},
----------------
This one should query the wavesize?


================
Comment at: lib/Target/AMDGPU/SIInstructions.td:606-614
 def : Pat <
-  (int_amdgcn_icmp i1:$src, (i1 0), (i32 33)),
+  (i64 (int_amdgcn_icmp i1:$src, (i1 0), (i32 33))),
+  (COPY $src) // Return the SGPRs representing i1 src
+>;
+
+def : Pat <
+  (i32 (int_amdgcn_icmp i1:$src, (i1 0), (i32 33))),
----------------
I don't think these should ever get here? These should have been turned into AMDGPUSsetcc


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63301/new/

https://reviews.llvm.org/D63301