[PATCH] D63286: [GlobalISel][IRTranslator] Don't add debug info to constants emitted into the entry block

[Amara Emerson via Phabricator via llvm-commits]

aemerson marked an inline comment as done.
aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:1722
+  // debug behaviour.
+  EntryBuilder->setDebugLoc(DebugLoc());
   switch(Inst.getOpcode()) {
----------------
aprantl wrote:
> If you are inserting an instruction into the entry block without a DebugLoc and there is no instruction with a DebugLoc before it, it will get added to the function prologue. This may not matter, but I just wanted to make sure that you are aware of that.
Thanks for the heads up. That seems reasonable to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63286/new/

https://reviews.llvm.org/D63286