[llvm] r363298 - [lit] Disable test on darwin when building shared libs.

Don Hinton via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 13 12:08:49 PDT 2019


Author: dhinton
Date: Thu Jun 13 12:08:49 2019
New Revision: 363298

URL: http://llvm.org/viewvc/llvm-project?rev=363298&view=rev
Log:
[lit] Disable test on darwin when building shared libs.

Summary:
This test fails to link shared libraries because tries to run
a copied version of clang-check to see if the mock version of libcxx
in the same directory can be loaded dynamically.  Since the test is
specifically designed not to look in the default just-built lib
directory, it must be disabled when building with
BUILD_SHARED_LIBS=ON.

Currently only disabling it on Darwin and basing it on the
enable_shared flag.

Reviewed By: ilya-biryukov

Tags: #clang, #llvm

Differential Revision: https://reviews.llvm.org/D61697

Modified:
    llvm/trunk/utils/lit/lit/llvm/config.py

Modified: llvm/trunk/utils/lit/lit/llvm/config.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/llvm/config.py?rev=363298&r1=363297&r2=363298&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/llvm/config.py (original)
+++ llvm/trunk/utils/lit/lit/llvm/config.py Thu Jun 13 12:08:49 2019
@@ -48,6 +48,8 @@ class LLVMConfig(object):
             # We should standardize on the former.
             features.add('system-linker-mach-o')
             features.add('system-darwin')
+            if config.enable_shared:
+                features.add("enable_shared")
         elif platform.system() == 'Windows':
             # For tests that require Windows to run.
             features.add('system-windows')




More information about the llvm-commits mailing list