[PATCH] D61228: [PowerPC] Set the innermost hot loop(from PGO) to align 32 bytes

[Jinsong Ji via Phabricator via llvm-commits]

jsji accepted this revision.
jsji added a comment.
This revision is now accepted and ready to land.

LGTM, some comments /renaming can be done before committing. Thanks.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:113
 
+static cl::opt<bool> DisableHotLoopAlign32("disable-ppc-hot-loop-align32",
+cl::desc("don't always align hot loops(from PGO) to 32 bytes on ppc"), cl::Hidden);
----------------
We only apply to innermost loops, can we use something like `DisableInnerMostLoopAlign32` / `disable-ppc-innermost-loop-align32`


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:114
+static cl::opt<bool> DisableHotLoopAlign32("disable-ppc-hot-loop-align32",
+cl::desc("don't always align hot loops(from PGO) to 32 bytes on ppc"), cl::Hidden);
+
----------------
We don't read information from PGO any more, so maybe remove `from PGO` please.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61228/new/

https://reviews.llvm.org/D61228