[PATCH] D63162: GlobalISel: Avoid producing Illegal copies in RegBankSelect
Quentin Colombet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 13 10:11:03 PDT 2019
qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.
LGTM.
Nitpicks below.
================
Comment at: lib/CodeGen/GlobalISel/RegisterBankInfo.cpp:252
return getInvalidInstructionMapping();
+ }
----------------
>From LLVM standard: no brackets here.
================
Comment at: lib/CodeGen/GlobalISel/RegisterBankInfo.cpp:418
+ PossibleMappings.push_back(&Mapping);
+ }
+
----------------
Ditto
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63162/new/
https://reviews.llvm.org/D63162
More information about the llvm-commits
mailing list