[PATCH] D63084: [llvm-readobj] Don't abort printing of dynamic table if string reference is invalid

[Yuanfang Chen via Phabricator via llvm-commits]

ychen marked 5 inline comments as done.
ychen added a comment.

Thank you @jhenderson @MaskRay. If this looks good, could you commit it for me?



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1942
+    OS << TagNames.at(Type) << ": ";
+    if (DynamicStringTable.size() == 0)
+      OS << "<String table is empty or was not found> ";
----------------
jhenderson wrote:
> ychen wrote:
> > MaskRay wrote:
> > > DynamicStringTable.empty()
> > done
> Tip: you can mark individual comments as "Done" by clicking the "Done" button in the comment box header. I find it quite useful when reviewing code if that has been done.
Oh, that's much better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63084/new/

https://reviews.llvm.org/D63084