[PATCH] D63239: [llvm-objcopy] Refactor output target parsing

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.h:53
 
+struct TargetInfo {
+  FileFormat Format;
----------------
As this is only used in the .cpp, it can be moved in there.


================
Comment at: llvm/tools/llvm-objcopy/llvm-objcopy.cpp:134
+  // output format is binary/ihex or it's not given. This behavior differs from
+  // GNU objcopy. See https://bugs.llvm.org/show_bug.cgi?id=42171
+  case FileFormat::Binary:
----------------
Missing trailing full stop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63239/new/

https://reviews.llvm.org/D63239