[PATCH] D63266: [llvm-readobj] - Do not fail to dump the object which has wrong type of .shstrtab.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:3012
+  if (!Index || Index >= Sections.size())
+    report_fatal_error("invalid section index");
+  StringRef Data = toStringRef(
----------------
Could this call `reportError(Twine)` at least? Ideally, I'd prefer it if it called a function that included the file name too. I think there's one in llvm-readobj.cpp that would be useful: `reportError(StringRef Input, Error Err)`. I don't see a reason that this couldn't be exposed to the rest of llvm-readobj.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63266/new/

https://reviews.llvm.org/D63266