[PATCH] D63238: [llvm-objcopy] Add elf32-sparc target

Thu Jun 13 04:05:14 PDT 2019

seiya added a comment.

In D63238#1541370 <https://reviews.llvm.org/D63238#1541370>, @jhenderson wrote:

> In D63238#1541295 <https://reviews.llvm.org/D63238#1541295>, @seiya wrote:
>
> > In D63238#1541201 <https://reviews.llvm.org/D63238#1541201>, @jhenderson wrote:
> >
> > > Looks good, I think, but does GNU objcopy have sparc as -I/-O type? Is the syntax the same as you have used?
> >
> >
> > Yes, it has the same target name. I'm not familiar with SPARC at all, but now I noticed that 32-bit SPARC is big endian and `gnu-objcopy -Oelf32-sparc` certainly emits a big endian ELF file. I think I should fix the SPARC entry in `ArchMap` before committing this patch. What do you think on this?
>
>
> I'm not familiar with SPARC either. Are you confident about it being big endian? If so, fixing the map seems fine and relevant. I have no problem with you adding the sparcel target if you want.

According to `bfd/elf32-sparc.c` in GNU binutils and `clang/lib/Basic/Targets/Sparc.h`, it seems to be big endian. I'll submit another patch for this.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63238/new/

https://reviews.llvm.org/D63238