[PATCH] D62669: [ARM] Set up infrastructure for MVE vector instructions.

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 13 03:48:23 PDT 2019


simon_tatham updated this revision to Diff 204479.
simon_tatham marked an inline comment as done.
simon_tatham added a comment.

I think this revision addresses all the previous review comments. In
particular, `IT` and `VPT` mask handling is now identical, because
`IT` handling was simplified by D63219 <https://reviews.llvm.org/D63219> (which also introduced that
helper function @ostannard asked for to do the mask bit extraction).

Also I've moved the tests that aren't specifically about VPT into test
files that further MVE assembly patches will add more things to. (Each
of the handful of example instructions in this patch is pulled forward
from one of those later patches, and now when those later patches
land, each one will end up being tested in the same test input files
as its siblings.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62669/new/

https://reviews.llvm.org/D62669

Files:
  llvm/lib/Target/ARM/ARMBaseInstrInfo.h
  llvm/lib/Target/ARM/ARMInstrFormats.td
  llvm/lib/Target/ARM/ARMInstrMVE.td
  llvm/lib/Target/ARM/ARMRegisterBankInfo.cpp
  llvm/lib/Target/ARM/ARMRegisterInfo.td
  llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  llvm/lib/Target/ARM/Disassembler/ARMDisassembler.cpp
  llvm/lib/Target/ARM/MCTargetDesc/ARMInstPrinter.cpp
  llvm/lib/Target/ARM/MCTargetDesc/ARMInstPrinter.h
  llvm/lib/Target/ARM/MCTargetDesc/ARMMCCodeEmitter.cpp
  llvm/lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.h
  llvm/lib/Target/ARM/Utils/ARMBaseInfo.h
  llvm/test/MC/ARM/mve-minmax.s
  llvm/test/MC/ARM/mve-reductions.s
  llvm/test/MC/ARM/mve-vpt.s
  llvm/test/MC/Disassembler/ARM/mve-minmax.txt
  llvm/test/MC/Disassembler/ARM/mve-reductions.txt
  llvm/test/MC/Disassembler/ARM/mve-vpt.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62669.204479.patch
Type: text/x-patch
Size: 79259 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190613/e61289e9/attachment.bin>


More information about the llvm-commits mailing list