[PATCH] D63191: [lld][ELF] Check length of subsection in .ARM.attributes
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 13 02:21:42 PDT 2019
grimar accepted this revision.
grimar added a comment.
LGTM with one nit and Rui's comments addressed.
================
Comment at: tools/lld/test/ELF/bad-arm-attributes.s:1
+# RUN: llvm-mc -filetype=obj -triple=arm-unknown-linux %s -o %t
+# RUN: ld.lld %t -o %tout 2>&1 | FileCheck %s
----------------
ruiu wrote:
> Please move this to tools/lld/test/ELF/invalid directory.
I think you also need to add `# REQUIRES: arm`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63191/new/
https://reviews.llvm.org/D63191
More information about the llvm-commits
mailing list