[PATCH] D63244: Support wildcard patterns in --undefined.

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

Looks good to me as well.



================
Comment at: lld/ELF/Driver.cpp:1335
+  for (Symbol *Sym : Syms) {
+    Sym->IsUsedInRegularObj = true;
+    if (Sym->isLazy())
----------------
Might be worth extracting this block, and the equivalent one in handleUndefined into a separate function. That way the action to take to once a symbol has been selected by a pattern is always the same in both functions, including the comment about LTO. I've not got a strong opinion though as I don't expect much change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63244/new/

https://reviews.llvm.org/D63244