[PATCH] D63244: Support wildcard patterns in --undefined.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1327
+  Symtab->forEachSymbol([&](Symbol *Sym) {
+    // Calling Sym->fetch() from here not safe as it may add new
+    // symbols to the symbol table, invalidating the current iterator.
----------------
clang-format.

`here not` -> `here is not`


================
Comment at: lld/ELF/Driver.cpp:1343
 static void handleUndefined(StringRef Name) {
+  if (Name.contains('*') || Name.contains('?') || Name.contains('[')) {
+    Expected<GlobPattern> Pat = GlobPattern::create(Name);
----------------
`Name.find_first_of("?*[")`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63244/new/

https://reviews.llvm.org/D63244