[PATCH] D63046: [Attributor] Deduce "willreturn" function attribute

[Hideto Ueno via Phabricator via llvm-commits]

uenoku marked an inline comment as done.
uenoku added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1177
+        indicatePessimisticFixpoint();
+        return ChangeStatus::CHANGED;
+      }
----------------
jdoerfert wrote:
> I'd argue: Either do not check for noreturn at all, which I would have initially thought we do, or do it explicitly for this function but not the callees. That way, the function which is `noreturn` is not `willreturn` and callers will no be able to get `willreturn`. However, once `willreturn` is deduced, `noreturn` should be irrelevant (IMHO), maybe contradicting.
I agree with you.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63046/new/

https://reviews.llvm.org/D63046