[PATCH] D62982: build: extract LLVM distribution target handling

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 12 19:26:47 PDT 2019


smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

Ah, so just having variables to hold the different distribution sets? Makes sense ... you'd need to adjust the CMake exporting logic, and I'm not quite sure how that'll play out yet, but we can see when we get to that.

This LGTM.



================
Comment at: cmake/modules/LLVMDistributionSupport.cmake:1
+
+if(LLVM_DISTRIBUTION_COMPONENTS)
----------------
smeenai wrote:
> License header?
Never mind, looks like we don't usually put the license header in build files.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62982/new/

https://reviews.llvm.org/D62982





More information about the llvm-commits mailing list