[PATCH] D63104: Add GSYM utility files along with unit tests.

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added a comment.

Sorry I wasn't very quick to get to this. This looks really good to me. I'm going to go over some of the this with a fine tooth comb tomorrow but It basically looks good as at high level glance.



================
Comment at: include/llvm/DebugInfo/GSYM/StringTable.h:47
+  }
+  uint32_t find(StringRef Str) const {
+    // Return the first byte of the GSYM string table which contains the 
----------------
Return Option<uint32_t> instead.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63104/new/

https://reviews.llvm.org/D63104