[PATCH] D63234: AMDGPU: Change API for checking for exec modification

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 12 16:40:11 PDT 2019


arsenm created this revision.
arsenm added reviewers: rampitec, vpykhtin.
Herald added subscribers: kbarton, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, nemanjai, kzhuravl.

Invert the name and return value to better reflect the imprecise
nature.

      

Force passing in the DefMI, since it's known in the 2 users and could
ossibly fail for an arbitrary vreg.

      

Allow specifying a specific user instruction. Scan through use
instructions, instead of use operands. Add scan thresholds instead of
searching infinitely.

      

Stop using a set to track seen uses. I didn't understand this usage,
or why it would not check the last use. I don't think the order of the
use list has any particular order.


https://reviews.llvm.org/D63234

Files:
  lib/Target/AMDGPU/GCNDPPCombine.cpp
  lib/Target/AMDGPU/SIFoldOperands.cpp
  lib/Target/AMDGPU/SIInstrInfo.cpp
  lib/Target/AMDGPU/SIInstrInfo.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63234.204384.patch
Type: text/x-patch
Size: 5160 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190612/48f3b3c3/attachment.bin>


More information about the llvm-commits mailing list