[PATCH] D62939: Fix a bug w/inbounds invalidation in LFTR (was: Strengthen LFTR's ability to replace IVs)

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D62939#1540490 <https://reviews.llvm.org/D62939#1540490>, @nikic wrote:

> If the mustExecuteUBIfPoisonOnPathTo() check is performed, then, as you argue, we do handle `S` being poison properly. It's just that the check is only performed on pointers, but not integers (in this patch).


Ah, agreed.

> In any case, let's defer that one, this patch is about pointers. There's one last tweak I'd like to see here: If the condition already depends on the post-inc IV, then we can safely use it. Going through the test cases this is actually the case for most of the regressions in existing tests (I've left comments), so I think it would be very worthwhile to check this case.

Very nice observation!  Will incorporate and update shortly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62939/new/

https://reviews.llvm.org/D62939