[PATCH] D63152: [FIX] Forces shrink wrapping to consider any memory access as aliasing with the stack

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I'd prefer to take this soon, and deal with the performance later, given this is a serious bug.  I wouldn't be surprised if this is actually causing issues in practice, but nobody realized it because it's non-deterministic.



================
Comment at: lib/CodeGen/ShrinkWrap.cpp:261
                                  RegScavenger *RS) const {
+  /* This prevents premature stack poping when occurs a indirect stack
+   * access. It is overly agressive for the moment.
----------------
"popping".


================
Comment at: lib/CodeGen/ShrinkWrap.cpp:262
+  /* This prevents premature stack poping when occurs a indirect stack
+   * access. It is overly agressive for the moment.
+   * TODO: - Obvious non-stack loads and store, such as global values,
----------------
"aggressive".


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63152/new/

https://reviews.llvm.org/D63152