[PATCH] D62888: [NewPM] Port Sancov

Leonard Chan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 12 11:09:35 PDT 2019


leonardchan added a comment.

In D62888#1537233 <https://reviews.llvm.org/D62888#1537233>, @chandlerc wrote:

> I would just change this to have the module pass loop over the functions -- that seems like it'll be much cleaner.
>
> As it is, I'm not seeing where the loop actually happens. But rather than trying to figure that out, just seems better to turn it into an explicit loop. That way you can get rid of all the check analysis overhead I think.


Done. This simplifies the patch a lot more.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62888/new/

https://reviews.llvm.org/D62888





More information about the llvm-commits mailing list