[PATCH] D62838: [Object] add isExecutableObject member function
Alex Brachet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 12 10:11:58 PDT 2019
abrachet marked 9 inline comments as done.
abrachet added inline comments.
================
Comment at: llvm/unittests/Object/ObjectFileTest.cpp:48-51
+ ELF::ET_LOPROC + 20,
+ ELF::ET_LOPROC + 38,
+ ELF::ET_LOPROC + 50,
+ ELF::ET_LOPROC + 72,
----------------
jhenderson wrote:
> You probably only need one of these, but you should also add a value between LOOS and HIOS.
>
> You should probably even add an unused value from the standard range (e.g. ET_CORE + 1), or similar.
Which LOOS and HIOS should I use in the context of e_type?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62838/new/
https://reviews.llvm.org/D62838
More information about the llvm-commits
mailing list