[PATCH] D63218: X86: Clean up pass initialization

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 12 10:02:26 PDT 2019


craig.topper added a comment.

In D63218#1540221 <https://reviews.llvm.org/D63218#1540221>, @tstellar wrote:

> In D63218#1540190 <https://reviews.llvm.org/D63218#1540190>, @craig.topper wrote:
>
> > Is the initializeEdgeBundlesPass because X86FloatingPoint.cpp doesn't have its own initialize function that could call INTIALIZE_PASS_DEPENDENCY?
>
>
> Yes, that's what it looks like.  Do you want me to update the patch to give X86FloatingPoint.cpp its own initialize function?


That would probably be better. I think the initialize function is needed to make print-before-all/print-after-all see the pass so its good to have.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63218/new/

https://reviews.llvm.org/D63218





More information about the llvm-commits mailing list