[PATCH] D62907: [ARM] Implement TTI::isHardwareLoopProfitable

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 12 05:39:31 PDT 2019


thakis added a comment.

All these tests seem to fail when the ARM target isn't enabled, with errors like this:

  ********************
  FAIL: LLVM :: Transforms/HardwareLoops/ARM/counter.ll (25696 of 31777)
  ******************** TEST 'LLVM :: Transforms/HardwareLoops/ARM/counter.ll' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';   /Users/thakis/src/llvm-project/out/gn/bin/opt -mtriple=thumbv8.1m.main-arm-none-eabi -hardware-loops -disable-arm-loloops=false /Users/thakis/src/llvm-project/llvm/test/Transforms/HardwareLoops/ARM/counter.ll -o - | /Users/thakis/src/llvm-project/out/gn/bin/FileCheck /Users/thakis/src/llvm-project/llvm/test/Transforms/HardwareLoops/ARM/counter.ll
  --
  Exit Code: 2
  
  Command Output (stderr):
  --
  opt: Unknown command line argument '-disable-arm-loloops=false'.  Try: '/Users/thakis/src/llvm-project/out/gn/bin/opt --help'
  opt: Did you mean '  --disable-x86-lea-opt=false'?
  FileCheck error: '-' is empty.
  FileCheck command line:  /Users/thakis/src/llvm-project/out/gn/bin/FileCheck /Users/thakis/src/llvm-project/llvm/test/Transforms/HardwareLoops/ARM/counter.ll
  
  --
  
  ********************
  Testing Time: 266.30s
  ********************
  Failing Tests (6):
      LLVM :: Transforms/HardwareLoops/ARM/calls.ll
      LLVM :: Transforms/HardwareLoops/ARM/counter.ll
      LLVM :: Transforms/HardwareLoops/ARM/do-rem.ll
      LLVM :: Transforms/HardwareLoops/ARM/fp-emulation.ll
      LLVM :: Transforms/HardwareLoops/ARM/simple-do.ll
      LLVM :: Transforms/HardwareLoops/ARM/structure.ll

They probably all need a `REQUIRES: arm-registered-target`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62907/new/

https://reviews.llvm.org/D62907





More information about the llvm-commits mailing list