[PATCH] D61248: [NFC] Add the infrastructure to forward the scheduled state between MBB

[Lei Huang via Phabricator via llvm-commits]

lei added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineScheduler.h:228
+  /// Return true if save the scheduled state before leaving the MBB
+  /// successfully.
+  virtual bool saveScheduledState(MachineBasicBlock *MBB) { return false; }
----------------
Do you mean `Return true if scheduled state is saved successfully before leaving the MBB`?


================
Comment at: llvm/include/llvm/CodeGen/MachineScheduler.h:234
+
+  /// Return the single pred MBB if it has.
+  virtual MachineBasicBlock *getScheduledPredMBB(MachineBasicBlock *MBB);
----------------
Does `pred` mean `predecessor`?  I think it is best to use the full word for code documentation.


================
Comment at: llvm/include/llvm/CodeGen/MachineScheduler.h:234
+
+  /// Return the single pred MBB if it has.
+  virtual MachineBasicBlock *getScheduledPredMBB(MachineBasicBlock *MBB);
----------------
lei wrote:
> Does `pred` mean `predecessor`?  I think it is best to use the full word for code documentation.
Maybe this is more clear?
  /// Return predecessor if MBB have only a single predecessor.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61248/new/

https://reviews.llvm.org/D61248