[PATCH] D62904: [DebugInfo] Honour variable fragments in LiveDebugValues

Wed Jun 12 04:33:45 PDT 2019

jmorse marked 3 inline comments as done.
jmorse added inline comments.

================
Comment at: lib/CodeGen/LiveDebugValues.cpp:913
+      OverlappingFragments.insert({{MIVar.getVar(), ThisFragment}, {}});
+  if (!IsInOLapMap.second)
+    return;
----------------
aprantl wrote:
> Instead of having all these references to .second (and only .second) in this function, would it make sense to store a reference to .second in the auto variables and give them a different name?
> 
> i.e., `auto CurrentFragments = IsInOLapMap.first.second;`
I've added the ThisFragmentsOverlaps and AllSeenFragments references -- hopefully this makes the loop clearer, showing which parts are previously-seen fragments and which is the current (unseen) fragment.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62904/new/

https://reviews.llvm.org/D62904