[llvm] r363136 - [llvm-nm] Fix docs and help text for --print-size

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 12 03:44:41 PDT 2019


Author: jhenderson
Date: Wed Jun 12 03:44:41 2019
New Revision: 363136

URL: http://llvm.org/viewvc/llvm-project?rev=363136&view=rev
Log:
[llvm-nm] Fix docs and help text for --print-size

The --print-size help text and documentation claimed that the size was
printed instead of the address, but this is incorrect. It is printed as
well as the address. This patch fixes this issue.

Reviewed by: MaskRay, mtrent, ruiu

Differential Revision: https://reviews.llvm.org/D63142

Modified:
    llvm/trunk/docs/CommandGuide/llvm-nm.rst
    llvm/trunk/tools/llvm-nm/llvm-nm.cpp

Modified: llvm/trunk/docs/CommandGuide/llvm-nm.rst
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/CommandGuide/llvm-nm.rst?rev=363136&r1=363135&r2=363136&view=diff
==============================================================================
--- llvm/trunk/docs/CommandGuide/llvm-nm.rst (original)
+++ llvm/trunk/docs/CommandGuide/llvm-nm.rst Wed Jun 12 03:44:41 2019
@@ -121,7 +121,7 @@ OPTIONS
 
 .. option:: --print-size, -S
 
- Show symbol size instead of address.
+ Show symbol size as well as address (not applicable for Mach-O).
 
 .. option:: --size-sort
 

Modified: llvm/trunk/tools/llvm-nm/llvm-nm.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-nm/llvm-nm.cpp?rev=363136&r1=363135&r2=363136&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-nm/llvm-nm.cpp (original)
+++ llvm/trunk/tools/llvm-nm/llvm-nm.cpp Wed Jun 12 03:44:41 2019
@@ -147,7 +147,7 @@ cl::alias ReverseSortr("r", cl::desc("Al
                        cl::aliasopt(ReverseSort), cl::Grouping);
 
 cl::opt<bool> PrintSize("print-size",
-                        cl::desc("Show symbol size instead of address"),
+                        cl::desc("Show symbol size as well as address"),
                         cl::cat(NMCat));
 cl::alias PrintSizeS("S", cl::desc("Alias for --print-size"),
                      cl::aliasopt(PrintSize), cl::Grouping);




More information about the llvm-commits mailing list