[PATCH] D63084: [llvm-readobj] Don't abort printing of dynamic table if string reference is invalid
    James Henderson via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Jun 12 01:45:10 PDT 2019
    
    
  
jhenderson accepted this revision.
jhenderson added a comment.
My instinct is to say that the RPATH change should be a separate change, since it's not just about the improved error/warning. Please could you split it off (we still want it, just not in a commit to do with error messages). LGTM, aside from that.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63084/new/
https://reviews.llvm.org/D63084
    
    
More information about the llvm-commits
mailing list