[PATCH] D63076: [ELF][RISCV] Support PLT, GOT, copy and relative relocations

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 12 00:17:43 PDT 2019


ruiu added inline comments.


================
Comment at: ELF/Arch/RISCV.cpp:116
+void RISCV::writeGotHeader(uint8_t *Buf) const {
+  write64le(Buf, Main->Dynamic->getVA());
+}
----------------
ruiu wrote:
> For example, it looks like this code assumes RISCV64.
We have writeInt and writeUint to write word-size integers. Maybe you should use that?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63076/new/

https://reviews.llvm.org/D63076





More information about the llvm-commits mailing list