[PATCH] D63172: [Polly][NFC][ScopBuilder] Move addInvariantLoads to ScopBuilder

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

LGTM apart from the nitpicks.

I can commit for you when you think it's ready.



================
Comment at: polly/include/polly/ScopInfo.h:2335
 
+  /// Return an interator range containing invariant accesses
+  iterator_range<InvariantEquivClassesTy::iterator> invariantEquivClasses() {
----------------
[typo] interator

[nit] An iterator range does not contain any elements.

I usually don't nitpick on this: Sentence missing a dot at the end.


================
Comment at: polly/include/polly/ScopInfo.h:2336
+  /// Return an interator range containing invariant accesses
+  iterator_range<InvariantEquivClassesTy::iterator> invariantEquivClasses() {
+    return make_range(InvariantEquivClasses.begin(),
----------------
nice


================
Comment at: polly/lib/Analysis/ScopBuilder.cpp:1469
 
+bool isAParameter(llvm::Value *maybeParam, const Function &F) {
+  for (const llvm::Argument &Arg : F.args())
----------------
[suggestion] Make a static function?


Repository:
  rPLO Polly

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63172/new/

https://reviews.llvm.org/D63172