[PATCH] D63158: StackProtector: Use PointerMayBeCaptured

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 11 12:53:30 PDT 2019


arsenm created this revision.
arsenm added a reviewer: void.
Herald added subscribers: jfb, wdng.

This was using its own, outdated list of possible captures. This was
at minimum not catching cmpxchg and addrspacecast captures.

      

One change is now any volatile access is treated as capturing. The
test coverage for this pass is quite inadequate, but this required
removing volatile in the lifetime capture test.

      

Also fixes some infrastructure issues to allow running just the IR
pass.

      

Fixes bug 42238.


https://reviews.llvm.org/D63158

Files:
  lib/CodeGen/StackProtector.cpp
  test/CodeGen/X86/stack-protector.ll
  test/Transforms/StackProtector/X86/captures.ll
  test/Transforms/StackProtector/X86/lit.local.cfg
  tools/opt/opt.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63158.204134.patch
Type: text/x-patch
Size: 9376 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190611/eb912ee8/attachment.bin>


More information about the llvm-commits mailing list