[PATCH] D62670: [ARM] Add MVE horizontal accumulation instructions.

[Mikhail Maltsev via Phabricator via llvm-commits]

miyuki added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:307
+              list<dag> pattern=[]>
+  : MVE_rDest<(outs tGPREven:$Rda), (ins tGPREven:$Rda_src, MQPR:$Qm), NoItinerary,
+              !strconcat("vaddv", acc), suffix, "$Rda, $Qm", "$Rda = $Rda_src",
----------------
dmgreen wrote:
> As a corollary to what Oliver was saying. The VADDV (or in VADDVs8no_acc) doesn't really take a Rda_src, I believe. At least the structure you would match from llvm would not. There's a perfectly good chance it's possible and I just don't know how to represent that in a pattern. But it seems more natural to make sure that VADDVs*no_acc don't require a Rda_src.
> 
> When I looked at this downstream, I just ended up splitting this into two classes. 
>But it seems more natural to make sure that VADDVs*no_acc don't require a Rda_src.
This also pertains to VMLADAV, VMLSDAV, etc, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62670/new/

https://reviews.llvm.org/D62670