[PATCH] D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time.

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 11 10:12:47 PDT 2019


ychen added a comment.

In D63115#1537527 <https://reviews.llvm.org/D63115#1537527>, @MaskRay wrote:

> The code change looks good. Thanks!


Thank you for the review. Test file name updated to reflect the comment in it.



================
Comment at: llvm/tools/llvm-readobj/llvm-readobj.cpp:469
     Dumper->printLoadName();
+    Writer.flush();
   }
----------------
jhenderson wrote:
> I thought the idea of the change was to avoid the need for the explicit flush?
You are correct. It helps me identify the root cause: opts::CodeViewMergedTypes also uses its own stream.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63115/new/

https://reviews.llvm.org/D63115





More information about the llvm-commits mailing list