[PATCH] D63138: [Analysis] add isSplatValue() for vectors in IR

[Shawn Landden via Phabricator via llvm-commits]

shawnl added a comment.

Looks fine



================
Comment at: llvm/lib/Analysis/VectorUtils.cpp:354
+  // If all operands of a select are splats, the result is a splat.
+  if (match(V, m_Select(m_Value(X), m_Value(Y), m_Value(Z))))
+    return isSplatValue(X, Depth) && isSplatValue(Y, Depth) &&
----------------
We do not currently normalize vector selects to select.

see https://bugs.llvm.org/show_bug.cgi?id=41777

Should we? (as long as it doesn't require defining undefs?).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63138/new/

https://reviews.llvm.org/D63138