[PATCH] D63142: [llvm-nm] Fix docs and help text for --print-size

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 11 08:26:44 PDT 2019


jhenderson created this revision.
jhenderson added reviewers: grimar, ruiu, rupprecht, mtrent, MaskRay.
Herald added a project: LLVM.

The --print-size help text and documentation claimed that the size was printed instead of the address, but this is incorrect. It is printed as well as the address. This patch fixes this issue.


Repository:
  rL LLVM

https://reviews.llvm.org/D63142

Files:
  docs/CommandGuide/llvm-nm.rst
  tools/llvm-nm/llvm-nm.cpp


Index: tools/llvm-nm/llvm-nm.cpp
===================================================================
--- tools/llvm-nm/llvm-nm.cpp
+++ tools/llvm-nm/llvm-nm.cpp
@@ -147,7 +147,7 @@
                        cl::aliasopt(ReverseSort), cl::Grouping);
 
 cl::opt<bool> PrintSize("print-size",
-                        cl::desc("Show symbol size instead of address"),
+                        cl::desc("Show symbol size as well as address"),
                         cl::cat(NMCat));
 cl::alias PrintSizeS("S", cl::desc("Alias for --print-size"),
                      cl::aliasopt(PrintSize), cl::Grouping);
Index: docs/CommandGuide/llvm-nm.rst
===================================================================
--- docs/CommandGuide/llvm-nm.rst
+++ docs/CommandGuide/llvm-nm.rst
@@ -121,7 +121,7 @@
 
 .. option:: --print-size, -S
 
- Show symbol size instead of address.
+ Show symbol size as well as address.
 
 .. option:: --size-sort
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63142.204078.patch
Type: text/x-patch
Size: 937 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190611/16d31018/attachment.bin>


More information about the llvm-commits mailing list