[PATCH] D63136: [yaml2obj] - Allow setting cutom Flags for implicit sections.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Do we have test cases anywhere for the sections' flags when they aren't described in the YAML?



================
Comment at: test/tools/yaml2obj/strtab-implicit-sections-flags.yaml:1
+## For implicit string table sections, `Flags` field can also
+## be specified in YAML. Here we test the behavior in different cases.
----------------
Nit: add "the" before Flags.


================
Comment at: test/tools/yaml2obj/strtab-implicit-sections-flags.yaml:5
+## When flags are not explicitly specified, yaml2obj assigns no flags
+## for .strtab and SHF_ALLOC flag for .dynstr by default.
+
----------------
and -> and the


================
Comment at: test/tools/yaml2obj/strtab-implicit-sections-flags.yaml:32-33
+
+## Check we can set arbitrary flags for .strtab/.dynstr and make
+## .strtab to be allocatable and .dynstr to be not allocatable.
+
----------------
I'd probably just remove the rest of the sentence from "and make .strtab ..."


================
Comment at: test/tools/yaml2obj/symtab-implicit-sections-flags.yaml:1
+## For implicit symbol table sections, `Flags` field can also
+## be specified in YAML. Here we test the behavior in different cases.
----------------
Same comments apply to this test as the other test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63136/new/

https://reviews.llvm.org/D63136