[PATCH] D63076: [ELF][RISCV] Support PLT, GOT, copy and relative relocations

Tue Jun 11 07:15:01 PDT 2019

jrtc27 added inline comments.

================
Comment at: test/ELF/riscv-plt.s:72
+  call foo
+  call bar
+  call bar at plt
----------------
MaskRay wrote:
> jrtc27 wrote:
> > This should never use a PLT stub.
> > This should never use a PLT stub.
> 
> Which function should not use a PLT stub? I think the behavior is consistent with ld.bfd, foo doesn't get a PLT but weak and bar get PLT stubs.
Yes, and I'm 99% sure that's an unintended bug. If you delete the `call foo at plt`, then the `call bar` *doesn't* use a PLT stub.

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63076/new/

https://reviews.llvm.org/D63076