[PATCH] D63076: [ELF][RISCV] Support PLT, GOT, copy and relative relocations

[James Clarke via Phabricator via llvm-commits]

jrtc27 requested changes to this revision.
jrtc27 added inline comments.
This revision now requires changes to proceed.


================
Comment at: ELF/Arch/RISCV.cpp:124-125
+void RISCV::writePltHeader(uint8_t *Buf) const {
+  if (Config->EFlags & EF_RISCV_RVE)
+    error("PLT is not supported for RVE");
+
----------------
ruiu wrote:
> What is RVE?
RV32E, as opposed to RV32I; it only has 16 GPRs available.


================
Comment at: test/ELF/riscv-plt.s:2
+# REQUIRES: riscv
+# RUN: echo '.globl bar, weak; .type bar, at function; .type weak, at function; bar: weak:' > %t1.s
+
----------------
Can we put this in a file in Inputs rather than creating it dynamically?


================
Comment at: test/ELF/riscv-plt.s:72
+  call foo
+  call bar
+  call bar at plt
----------------
This should never use a PLT stub.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63076/new/

https://reviews.llvm.org/D63076