[PATCH] D63133: [llvm-dwarfdump] Simplify --ignore-case help text and documentation and grammar error

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 11 04:47:57 PDT 2019


jhenderson created this revision.
jhenderson added reviewers: aprantl, JDevlieghere, dblaikie, probinson.
Herald added a project: LLVM.

There was a typo in the --ignore-case help text that was copied into the llvm-dwarfdump command-guide. Additionally, this patch simplifies the wording, since it was unnecessarily verbose: the switch applies for searching in general and doesn't need explicitly stating different search modes (which might go out-of-date as options are added or removed).


Repository:
  rL LLVM

https://reviews.llvm.org/D63133

Files:
  docs/CommandGuide/llvm-dwarfdump.rst
  tools/llvm-dwarfdump/llvm-dwarfdump.cpp


Index: tools/llvm-dwarfdump/llvm-dwarfdump.cpp
===================================================================
--- tools/llvm-dwarfdump/llvm-dwarfdump.cpp
+++ tools/llvm-dwarfdump/llvm-dwarfdump.cpp
@@ -141,10 +141,9 @@
               "-name option can be used instead."),
          value_desc("name"), cat(DwarfDumpCategory));
 static alias FindAlias("f", desc("Alias for -find."), aliasopt(Find));
-static opt<bool>
-    IgnoreCase("ignore-case",
-               desc("Ignore case distinctions in when searching by name."),
-               value_desc("i"), cat(DwarfDumpCategory));
+static opt<bool> IgnoreCase("ignore-case",
+                            desc("Ignore case distinctions when searching."),
+                            value_desc("i"), cat(DwarfDumpCategory));
 static alias IgnoreCaseAlias("i", desc("Alias for -ignore-case."),
                              aliasopt(IgnoreCase));
 static list<std::string> Name(
Index: docs/CommandGuide/llvm-dwarfdump.rst
===================================================================
--- docs/CommandGuide/llvm-dwarfdump.rst
+++ docs/CommandGuide/llvm-dwarfdump.rst
@@ -53,8 +53,7 @@
 
 .. option:: -i, --ignore-case
 
-            Ignore case distinctions in when searching entries by name
-            or by regular expression.
+            Ignore case distinctions when searching.
 
 .. option:: -n <pattern>, --name=<pattern>
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63133.204018.patch
Type: text/x-patch
Size: 1395 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190611/cfc11845/attachment.bin>


More information about the llvm-commits mailing list