[PATCH] D60387: FileCheck [7/12]: Arbitrary long numeric expressions

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added inline comments.


================
Comment at: llvm/include/llvm/Support/FileCheck.h:105
+  /// AST. Therefore, \returns this variable's value.
+  Optional<uint64_t> eval() const { return Value; }
+
----------------
Maybe this should use Expected instead of Optional to report errors?


================
Comment at: llvm/lib/Support/FileCheck.cpp:738
+        std::vector<StringRef> UndefVarNames;
+        Substitution->getUndefVarNames(UndefVarNames);
+        if (UndefVarNames.empty())
----------------
Could this be replaced with Error/Expected so that there is no more need for getUndefVarNames/appendUndefVarNames calls?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60387/new/

https://reviews.llvm.org/D60387