[PATCH] D63121: [ELF] Make the rule to create relative relocations in a writable section stricter

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 11 02:04:28 PDT 2019


grimar added inline comments.


================
Comment at: ELF/Relocations.cpp:971
+  // Copy relocations (for STT_OBJECT) and non-PIC PLT (for STT_FUNC) are only
+  // possible if we are creating an executable.
+  if (Config->Shared ||
----------------
This comment is a bit unclear now. It says "Copy relocations ... are only possible if we are creating an executable",
what made sence before when the condition was `if (Config->Shared)`, but now it also allows
`Config->Pie`, which stands for position independent executable.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63121/new/

https://reviews.llvm.org/D63121





More information about the llvm-commits mailing list