[PATCH] D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

I have probably no more comments except 2 nits.



================
Comment at: llvm/include/llvm/DebugInfo/DIContext.h:32
+static const StringRef kDILineInfoBadString("<invalid>");
+static const StringRef kBadString("??");
+
----------------
Variable names should start from the upper case (LLVM coding style).


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:376
+void warn(const Twine &Message) {
   WithColor::warning(errs(), ToolName) << Message << "\n";
 }
----------------
I guess you need to keep `errs().flush()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62462/new/

https://reviews.llvm.org/D62462