[PATCH] D63115: [llvm-readobj] Fix output interleaving issue caused by using multiple streams at the same time.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 11 00:44:33 PDT 2019
MaskRay added a comment.
The code change looks good. Thanks!
================
Comment at: llvm/test/tools/llvm-readobj/fix-interleaved-output.test:4
+
+# CHECK: Dynamic section at offset 0x1b8 contains 1 entries:
+# CHECK-NEXT: Tag Type Name/Value
----------------
You may add a comment (starting with `## `) explaining what the test intends to check.
Do you have a better name than `fix-interleaved-output.test`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63115/new/
https://reviews.llvm.org/D63115
More information about the llvm-commits
mailing list