[PATCH] D63100: [llvm-lipo] Update llvm-lipo docs for -archs flag

[Michael Trent via Phabricator via llvm-commits]

mtrent accepted this revision.
mtrent added a comment.

approving this revision in light of my notes inline. I still believe this command guide is going to need an editorial pass once all of the options are in. my main concern for the moment is that the information is accurate and complete.



================
Comment at: llvm/docs/CommandGuide/llvm-lipo.rst:34
+  Display unknown architectures as unknown(CPUtype,CPUsubtype).
+  Print architectures as a single word so -archs is suitable for shell scripting.
+
----------------
Hmmmm .... I'm going to provide this feedback so I'm not repeating the contents of the Apple man page, which may be under copyright. 

The main idea here is:

1. archs takes a single input file
2. each arch is printed by itself separated by whitespace. (It so happens that arches are also single words, but that's kind of obvious.)

These two facts taken together means that -archs is well suited for shell scripting, where can do something like "foreach i (`llvm-lipo -archs <file>`)"

My problem with the content here is that "  Print architectures as a single word so -archs is suitable for shell scripting." is clumsy and doesn't quite make sense. Easiest edit might just be to say:

"Take a single input file and display the architectures present in the file. Each architecture is separated only by whitespace. Unknown architectures are displayed as unknown(CPUtype,CPUsubtype)."

and let the chips fall where they may.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63100/new/

https://reviews.llvm.org/D63100