[PATCH] D63116: Let writeWindowsResourceCOFF() take a TimeStamp parameter

[Nico Weber via Phabricator via llvm-commits]

thakis created this revision.
thakis added a reviewer: hans.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

For lld, pass in Config->Timestamp (which is set based on lld's
/timestamp: and /Brepro flags). Since the writeWindowsResourceCOFF()
data is only used in-memory by LLD and the obj's timestamp isn't used
for anything in the output, this doesn't change behavior.

For llvm-cvtres, add an optional /timestamp: parameter, and use the
current behavior of calling time() if the parameter is not passed in.

This doesn't really change observable behavior (unless someone passes
/timestamp: to llvm-cvtres, which wasn't possible before), but it
removes the last unqualified call to time() from llvm/lib, which seems
like a good thing.


https://reviews.llvm.org/D63116

Files:
  lld/COFF/DriverUtils.cpp
  llvm/include/llvm/Object/WindowsResource.h
  llvm/lib/Object/WindowsResource.cpp
  llvm/test/tools/llvm-cvtres/timestamp.test
  llvm/tools/llvm-cvtres/Opts.td
  llvm/tools/llvm-cvtres/llvm-cvtres.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63116.203961.patch
Type: text/x-patch
Size: 6295 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190611/d068d5ee/attachment.bin>