[PATCH] D62991: [yaml2obj][MachO] Don't fill dummy data for virtual sections

Mon Jun 10 19:27:33 PDT 2019

seiya marked an inline comment as done.
seiya added inline comments.

================
Comment at: llvm/test/ObjectYAML/MachO/virtual_section.yaml:85
+        reserved2:       0x00000000
+        reserved3:       0x00000000
+  - cmd:             LC_BUILD_VERSION
----------------
compnerd wrote:
> I think that the `__TEXT,__eh_frame` is unnecessary for the test as is `__LD,__compact_unwind` and `___DATA,__common`.  It would be nice to have the TLS and the large zero-filled section in the test.
Hmm, in my environment (macOS 10.14.5), `clang -m32` emits a corrupted object file if the input has large (4GiB) zero-filled section. Do you know an example of S_GB_ZEROFILL sections?

That said, possibly S_GB_ZEROFILL is no longer used because we use 64-bit binaries.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62991/new/

https://reviews.llvm.org/D62991