[PATCH] D62088: [compiler-rt][builtins] Scaled Integer log10()

Sterling Augustine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 10 17:31:51 PDT 2019


saugustine added a comment.

I am absolutely not the right person to review the math. I think we need to trust that the author has it correct. The logic looks reasonable and the tests look basically thorough. I am inclined to accept it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62088/new/

https://reviews.llvm.org/D62088





More information about the llvm-commits mailing list