[PATCH] D62607: LoopDistribute/LAA: Respect convergent

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopDistribute.cpp:805
+    if (LAI->hasConvergentOp() && !Checks.empty()) {
+      return fail("RuntimeCheckWithConvergent",
+                  "may not insert runtime check with convergent operation");
----------------
Meinersbur wrote:
> Is there a reason to not check `Pred.isAlwaysTrue()` and `!Checks.empty()` in the same conditional?
This is trying to early return to avoid all of the partitioning


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62607/new/

https://reviews.llvm.org/D62607