[PATCH] D63107: Setup testing target dependencies for default runtimes

[Chris Bieneman via Phabricator via llvm-commits]

beanz created this revision.
beanz added reviewers: phosek, compnerd.
Herald added a subscriber: mgorny.
Herald added a project: LLVM.

The default runtimes targets aren't getting their dependencies configured correctly which results in check-runtimes failing when built from a clean build.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D63107

Files:
  llvm/runtimes/CMakeLists.txt


Index: llvm/runtimes/CMakeLists.txt
===================================================================
--- llvm/runtimes/CMakeLists.txt
+++ llvm/runtimes/CMakeLists.txt
@@ -352,6 +352,7 @@
     cmake_parse_arguments(ARG "" "" "DEPENDS;PREFIXES" ${ARGN})
 
     include(${LLVM_BINARY_DIR}/runtimes/Components.cmake OPTIONAL)
+    set(SUB_CHECK_TARGETS ${SUB_CHECK_TARGETS} PARENT_SCOPE)
     set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS ${LLVM_BINARY_DIR}/runtimes/Components.cmake)
 
     foreach(runtime_name ${runtime_names})
@@ -497,6 +498,7 @@
       runtime_default_target(
         DEPENDS ${deps}
         PREFIXES ${prefixes})
+      set(test_targets check-runtimes)
     else()
       if("default" IN_LIST LLVM_RUNTIME_TARGETS)
         runtime_default_target(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63107.203935.patch
Type: text/x-patch
Size: 789 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190610/2fb380f1/attachment.bin>