[PATCH] D63036: [RFC] LLVM IR constant expressions never trap.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: lib/Analysis/ValueTracking.cpp:489
+      if (V == I || !isa<Instruction>(V) ||
+          isSafeToSpeculativelyExecute(cast<Instruction>(V))) {
        EphValues.insert(V);
----------------
efriedma wrote:
> jdoerfert wrote:
> > `V == I` implies `isa<Instruction>(V)` and you can use `isSafeToSpeculativelyExecute(I)`
> I think you're reading this backwards; isSafeToSpeculativelyExecute only executes if `V != I`
I was, :( 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63036/new/

https://reviews.llvm.org/D63036